fix: reject unknown critical cert extensions#43
Merged
leopoldjoy merged 1 commit intoJul 6, 2026
Merged
Conversation
leanthebean
force-pushed
the
security/reject-unknown-critical-extensions
branch
3 times, most recently
from
June 26, 2026 17:03
6d521a7 to
6e222cf
Compare
leanthebean
force-pushed
the
security/reject-unknown-critical-extensions
branch
from
July 6, 2026 17:35
6e222cf to
1435ea5
Compare
leopoldjoy
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CAT finding
7895879c-27dc-4910-be03-948111c824cc.CertManager._verifyExtensionspreviously only parsed the critical flag for the two supported extension OIDs, BasicConstraints and KeyUsage. Unknown extension OIDs were skipped without checking whether the extension was marked critical, which is not compliant with RFC 5280 path validation behavior.This change:
criticalBOOLEAN before dispatching on the extension OID;unsupported critical extension.Self Review
Reviewed the final diff before opening this PR. The production change is scoped to the extension loop in
_verifyExtensions; valid AWS Nitro critical BasicConstraints/KeyUsage handling is unchanged, unknown non-critical extensions remain forward-compatible, and only unrecognizedcritical=TRUEextensions now fail closed.Tests
forge test --match-path test/CertManager.t.sol -vvvforge test